From 0515a93926a1cf5fea9d0039c694b9b021cf2166 Mon Sep 17 00:00:00 2001 From: modzeleg Date: Fri, 26 Mar 2021 15:41:35 +0100 Subject: [PATCH 1/8] T235 removed JSON object --- .../klaus/repository/EventRepositoryImpl.java | 6 ++---- .../repository/EventRepositoryImpl.class | Bin 8216 -> 8076 bytes 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/release11/klaus/repository/EventRepositoryImpl.java b/src/main/java/com/release11/klaus/repository/EventRepositoryImpl.java index 906aa4e..e8c0698 100644 --- a/src/main/java/com/release11/klaus/repository/EventRepositoryImpl.java +++ b/src/main/java/com/release11/klaus/repository/EventRepositoryImpl.java @@ -63,12 +63,10 @@ public class EventRepositoryImpl implements EventRepository { private List parseEvents(List eventStrings) { List events = new ArrayList<>(); for (String eventString : eventStrings) { + eventString = eventString.replaceAll("\\R", ""); try { - eventString = eventString.replaceAll("\\R", ""); events.add(objectMapper.readValue(eventString, Event.class)); - JSONObject jsonObject = new JSONObject(eventString); - - } catch (JsonProcessingException | JSONException e) { + } catch (JsonProcessingException e) { e.printStackTrace(); } } diff --git a/target/classes/com/release11/klaus/repository/EventRepositoryImpl.class b/target/classes/com/release11/klaus/repository/EventRepositoryImpl.class index 9daf232b1fc146abe10d804f3ec98daaa3df0fda..e4cf001a88f51eb8b22fb4447bbea68c2ee8b06b 100644 GIT binary patch delta 1865 zcmZ`(TWnNS6kU5dbMMTZ%XB(+rZa6VrNu<1t6Tm?9L)qo9Ra{1J_0S_y&;l`?Y-AI z`#jn5$QT#>Q!@>YwvGFR_3JUM)TeB{`Je}&k^QOL3 z_bLl}@vMp01i`hbdr}QOsdcLxmUXRN)t&ZYpTO7CyLv-9wc(DHK6tU;#v6E3E%4VE z2W-5JgKE9M$#~Dk`}jb;pfsseBwjtkFEcU0l%$~8k>u|5nx2N%-ku(6vZi-kP-dx@BaMOCmdueB zQ|7WenWu&#`^)AF45><1NfoIVYU)L{_{0jzVs)EU;$GpE>(%j+8d;_S(YX6YL4_)c zR;U%xK*?SRzCi&(T4CDXaVuRIRGDbl{2o6r@}t@qeL#+?@>oOW7^AacaP7r${KU7m ze#S5SQ(M2%ayixs4DsIpQaFj<;KoEO!YNuF{LXkKV;X+~r}L;YdDK~=&M_W+$xwo~m;>>*aWzI1G(t~O3qFIM0$3_Cfy@^yFN zZ;Uu~ci{pp7tX1{(w55e{LANJ5Oj|wxX5rA5hua8vcAkwMj|W|n89XdQj{caMKe}n z7IfNajLk*`E>Tnu5wip$ECm!~RJfEQh!!rzR)&~iRGKW_mBXLH8K+E*I<3nDI@v9? zu}$1R%#U2jr%098L<$Ivp;VU)NR(uH-#T|=)6F~aOnYJg&kL5;58yt*Q)pJVmnSlt zVI@5=Pd|2VzO=7yE7MLwD;9E)-Ow%9z{jSbJ( zGXn7G<0ZL>E{j#S$i$-f<6Hg)N$%SMHVQH(r6h_HugXqWXV! zxTOTR7cPlPj1U$lr5u|w+Dmw$mZLzbWxPztS+zN3$g6vzMPb>_X9H;;C@%(SnC7E3AZOkrecl>wmz%2G;M1`vwGOlwmpq(j=l zkZ3X{#`wiVllwu9qVTCP@`0wIO+j%16>(ppxPan<8v-tXlmec6XF4q*#`*BxdH4M1 zcb0q4eQf?ywdV2b2M+_7P51PgWoFalSXX_Boa74ZK2_A)aviMZGybVc<1F z#s9GDceS?dh;NN`nmB@^2HvpnCOQbYqx`glkhOzD#Ut@(>$bIB(bhH-$MC#?w+Y@+ zeKK8F0p20Fx5wJMn7w3J2;!%%RKW*VVd@pu;s`Vc&oWW1xgeUCyg)mJ--Fd?6 zEbLokopD&cFR7WfhH#Dao5t z*_@@*OzE9vQIYi4h`qk5k~`(nY>NuW_L9w-xpLtyi+tqw(tL5&7jV~kXaS}ev{01z zZK@Zu{nIm-n6#9Z8Pvc9(Q>iNf3#)=L8sDiDU~v2rNpeVD2H;rwB|o{x!FZ)MOS{g zV*_EbIGvX-PURcp${J&_Z98`u)J!N&t@>sj1L0?6AV;>H?O*xOX*kZ`3$T#w9K48q z{5IM58_u%wcTryO5S8s%n*}C?|c1StC^^^`4ae3Wilc zsk$l?;(vIc4Z||<;1JdznH$qo@inRBESB0Rl*w_zA%@8<*?b7kZXCdKD}saAOK6%p zhzAHyW3f126igh#;6~dqfJ0$t56rOBcJ|}-o*M&I`x!O~O<0Y?srRc4JjcKQp8}wk z+gZn+g_wp#{H$l~GFC4^1WU024cLU`80ky|P8vs<+?h$JrY!D}?965)Mq0C39SELh ztW!-&w#Ls%NZDo8kfiS#ugQk+j$T8SfpYH24Nk>rz@@(Af&l^EtRq9vhgdKB2fu<_YR3e*mAJ09oRdvZT z>yvvdR!qoGq_$=OygV{quPJAggUKji#>jf~V4xo#%5h3!b(K|E;gS{W>KL(rXFg93 zBy;%6NO9z-Nsbu^y7Ta9KR(-^W+jranPXt4I`k4|Qoe#|@ Date: Fri, 26 Mar 2021 15:44:27 +0100 Subject: [PATCH 2/8] T235 depracated code removed --- .../klaus/service/KlausServiceImpl.java | 6 +----- .../klaus/service/KlausServiceImpl.class | Bin 6598 -> 6389 bytes 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/main/java/com/release11/klaus/service/KlausServiceImpl.java b/src/main/java/com/release11/klaus/service/KlausServiceImpl.java index 48bee88..851db51 100644 --- a/src/main/java/com/release11/klaus/service/KlausServiceImpl.java +++ b/src/main/java/com/release11/klaus/service/KlausServiceImpl.java @@ -19,7 +19,7 @@ import java.util.UUID; import java.util.stream.Collectors; /** - * Service for {@link com.release11.klaus.controller.KlausController} and {@link com.release11.klaus.controller.MockController} + * Service for {@link com.release11.klaus.controller.MockController} and {@link com.release11.klaus.controller.MockController} * Allows for performing CRUD operations on {@link MockedMessageDto} * @author Rafał Żukowicz * @author Gabriel Modzelewski @@ -84,7 +84,6 @@ public class KlausServiceImpl implements KlausService { return mockedMessageDto; } -// TODO: Remove code of no use /** * Allows to modify mocked message. If message of given id and key-uuid doesn't exist a new entry is created * @param mockedMessageDto message to be saved @@ -94,9 +93,6 @@ public class KlausServiceImpl implements KlausService { @Override public ResponseEntity setMockedResponse(MockedMessageDto mockedMessageDto) { mockedResponseRepository.save(mockedMessageMapper.mockedMessageDtoToMockedMessage(mockedMessageDto)); - String s = objectMapper.writeValueAsString(mockedMessageDto); - String s1 = mockedMessageDto.toString(); - String s2 = String.valueOf(mockedMessageDto); log.info(mockedMessageDto.toString().replaceAll("\"", "\\\\\"")); return new ResponseEntity<>("MockedResponse has been setup successfully!", new HttpHeaders(), HttpStatus.ACCEPTED); diff --git a/target/classes/com/release11/klaus/service/KlausServiceImpl.class b/target/classes/com/release11/klaus/service/KlausServiceImpl.class index 24347a7f38cb0ee26b7e32d3c495ac66430720e1..6cac428ec54c30a56b49328453c851f71c750bd3 100644 GIT binary patch delta 963 zcmZWoOGs2<6#o7@j-xZzaUAbFB#d6rI1fRJObunIg)IVi5eOy(iPEm7MGK*AZQ_T5 z2!a+trKOJ3_{<(=Wo1_OwzBub-es?a^!?Xy6k6PS?m7QC-*>+ApF6Z-s>D7#-E#&& z8UD80cRMn(a9kiHYc#)%>7L9MgluS)`}BN!HgufQ(S~-p-w}1h(P=|M$7v*GyIzyg zEfA3PE<=vy81YEX9*fo#kkJgUoN#*OURP1PFt18DC+v8J=Qh01k&TzK(LHE?EnpFK zA`5Tj>iosd_jXL;gAE^be8T7W*8EjM!%unGD6-~Qf$LH)~m0bI1kON zxPU>T4Kb?W5-!qaYfJ=Fz~sv)H_665RW);DWiS|Df(p`=nPgs;gT%9B#VN8G;43Du zRhYm6!??=yKH20wAjYJ{w@mcQfUlxibzKb``)a^UUq0008m?1G5bH658?a(KYe#XD zZ2_?~VJxjKmQr_%=Q<_KVB99gf9mewu2RRuLj*2Rh?T)kIQT?E-8iD58%H&4l(~L? z^RZq8HYE}4KyeZ)+cty;%wd*u3I~ZY#$sO2E*rhMN!4*uo3R}A%&IjfwTQWEQWDh6 zD$^1wO@ShH8TV#qHo_!YvR_s&=H4EQHpt# z3)tLu#@vK$#1{PEpD=}A_=5sGWL(1|jMJ(HAJabJ<0tV``mfCQ8@!|c1z+*)A5;mx AXaE2J delta 1121 zcmZXT+iz4=6vlu1%nZ|+IS$j4(-t&sf)cDVZ4oq*(nK@S2aKU@YJ$OFaKNTe3lD8A zkCXThVB8uKeK9_05HGYtZ-AguQ1O1Ng7t>?`xWtuerLB76Ccjrd#%0J`quZYeNL}9 zc18O5+5LxrR+AV`-Fo=CFSXP6N~!RD$9iwwbz{;h-E>q>oh zbQcG19PHn^y~nW3wlBDFabIbB&+=JUTbg^>=QF@a6=Qa1=JI6|6p~CDa=oRY(sCEu zv8lIv^I)0-98B`0&mj)m7QfRxT`Buxv78w&cmpen(V^jIMK8IBNR%HAKY*>Y6AfVkEI8Jeh}nM-Klm^^vsU&XUL zCks}wjpvmgopx{>&t<&8i>mgrydJOclJ=CRKoo+4UuCreyP@Wq&huccgz{fZo8Vd< zSgq0#@Hw!SIk4Hnuerhr;|d#I=M9BV*^@Q9%#7`?U22ZnUA1lHsOvQ()z=ng`>JCD zZ}OIyfRTH*&6Sv#{by8$NLdG1HdQ9?=$4#<#7shyOt(Kkbg$XLF<0I5XR&ZBv_Zas~(%|W}EL|Ur9-wjk zIQbD;#<_Cu+NQ%!^L9G8Phc~`sKT6~BPlzQv_XvFR>CqR>e(b+H`B;%Qny=4w>W*T z*68b5$p;#jr-)`gbc1W;Qa;itPUoB~(Hy$wW$ALFnYjUFTl@QIN>>ifibFD_t5A|{Wd4=;xA=h%9yAN4NP8q5e{jnk)34cLM z0XcWIM|%~Yh=g(IOI#W~qym3}{T1pWNb?`ai$w6Oe1XdLN}7L28T8M@SqMFRdx_786TiC<*@$zS~aFGgAE7ytkO From 33a42eda7538020771b4c368a00ac2739c0d54da Mon Sep 17 00:00:00 2001 From: modzeleg Date: Fri, 26 Mar 2021 15:49:09 +0100 Subject: [PATCH 3/8] T235 removed unnecessary constructors --- .../java/com/release11/klaus/model/MockedMessageDto.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/main/java/com/release11/klaus/model/MockedMessageDto.java b/src/main/java/com/release11/klaus/model/MockedMessageDto.java index 7c462ff..21b5e6d 100644 --- a/src/main/java/com/release11/klaus/model/MockedMessageDto.java +++ b/src/main/java/com/release11/klaus/model/MockedMessageDto.java @@ -30,15 +30,6 @@ public class MockedMessageDto implements Serializable, Comparable httpHeaders) { - this.clientUUID = clientUUID; - this.httpHeaders = httpHeaders; - } - @Override public int compareTo(MockedMessageDto message) { return this.mockedResponseId > message.getMockedResponseId() ? 1 : -1; From deafb3841416b6423e89a8c765b7e38008581c79 Mon Sep 17 00:00:00 2001 From: modzeleg Date: Fri, 26 Mar 2021 15:53:05 +0100 Subject: [PATCH 4/8] Fixed misspath in put request of MockControlelr --- .../klaus/controller/MockController.java | 2 +- .../klaus/controller/MockController.class | Bin 9601 -> 9593 bytes .../klaus/model/MockedMessageDto.class | Bin 6465 -> 6114 bytes 3 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/release11/klaus/controller/MockController.java b/src/main/java/com/release11/klaus/controller/MockController.java index 794d173..6c0ecd3 100644 --- a/src/main/java/com/release11/klaus/controller/MockController.java +++ b/src/main/java/com/release11/klaus/controller/MockController.java @@ -34,7 +34,7 @@ public class MockController { * @return confirmation and 200 OK */ @SneakyThrows - @PutMapping("/") + @PutMapping public ResponseEntity updateMessage(@RequestBody String body){ ObjectMapper mapper = new ObjectMapper(); MockedMessageDto message = mapper.readValue(body, MockedMessageDto.class); diff --git a/target/classes/com/release11/klaus/controller/MockController.class b/target/classes/com/release11/klaus/controller/MockController.class index 0eb3c3e7e4d5ed1d70d91718bbfcf422e12e30f5..9577f6c3aef4e4d1d58b9b32ebe3baeb666f5062 100644 GIT binary patch delta 427 zcmYLFO)mpc6uoB{EvX`DMMZRmCm~UzEoEk^^_kELNkc-KkS@f=MjF;EEUYK-FC>y# ziH+Z3W$PcXb7rP=@p9ii=e=|8x%c&-+KWp0i>WsZ=(nw_n+pgm|0|u0&-4kfEP|4V z#0X=BO`eSoEU*Bpust>TeCCM8ejoG5u?9C6mOwI6lm`T?l3A3oCOxQ-Pmqg{Dv<&a z4eMB99ii$5&t_A!Hn!T>M#;0XV{pCQ?Db_NtBcu@9hT8ZR>mcPJ|l*?lv{TdTO+%PJr8fV_#)5#B}#v9$Z{Si!*a^=H!Vff#q1JCWI_>T zMhqNaN&5cTs@G#DJhrR5!lQI6u&2A&)2*0Q)M!GO{5$c9&N$_)hDwv_4a{&z{Te%C z?rWTzW^ve-WamJy%6SQ9Au77k&QaH!4 rTV>`tDUznr0=FqAFa8Y5b$+ZExG`p%+;L)?fv&gwuMH%fw*B=BUPe4~ diff --git a/target/classes/com/release11/klaus/model/MockedMessageDto.class b/target/classes/com/release11/klaus/model/MockedMessageDto.class index 4959b55cff7592f536a7328850b9e048f69fc890..b403a6c35a5081e2e50354968b697cdb1ee697c3 100644 GIT binary patch literal 6114 zcmcIo>vJ1d75`mX(n|8$mYvwHnrBnjwPmMjQku4M66!cfZLr-CCoX9VWFs&3*0SVE ztI!n6t31oAlt)7;Uz0UwP%(TcFjI#UA1yWtF)Y(DY^EtU71KBfuw?Oy#aBZF2>kFB^;8vW{vW6ZsagRVd*F688Dlc6V75ADL!hPhgxbFJ2 zZPB=@LQiP5Icr^OxZlKxoM1|j3$EqXs^Z41i7|}R!v(8!=J}dcROlZG+3@6*=j?(z zG5WNCA25-_g9=^r`BZ3keSx{9y0JD6Az2}bmLGxjdYwX%V{GXG4UuKQ!wQ$ z8@|{bsMX=(dqeD)FmYV)-5Re0P8=drCrx}9k9$+oVW0E{%CwE*6@i~JF(pwXI}&){ zn4>sj;;e*YV#TViOfkaym=Mz@X7CY(!8L2uo+_6Lmiv_Ba=KJ?t&&UEzvMfw;fatl zgNP5Y{9SFwsT&&t1X{uoUU$w>?3R7anV83u3@rxxx>d0+FdcIvvpWy{iP0GYA5++^ z56&s)7VL^+6`dEYD@EJDLNKF`W=bz2GYXmWwUX%U)n6=G#~#jY@%Bu<8!`ih=u zV)bj#+LqQk;6b-ebbA5~*Y)_w1}E)9LT>8~Kp~z7TWKo09;}JiqqPakE4OS94OGC2 zojX4>cZN=xVXLUv)mqVIn`_!>@6guGq=rJx)Z|OZJaeeYj86R;te0@hUX&;l!$+#S zb*NGVAs1q8TRfWU%|u8f&>~^*+W%*{9R}hyMm42Ra0%d16hnBQ?QvRKM0m4}_Hg_I zRGtYby{UzAtx~YhI?`JDy=u_7Vm=_viBU0cSDE@!Wm!ejr^;ow%AT_BRl#ac96wCq zNBFUU*QI}7R~TwsN1W2t@~WNl&d_V=XRU%;u3S^N?w^cqaz4;gI&GDfigtBqwp?DV zt%o=$9`Ho)NqmZL6vkyz3Kr=YBK?mmToF={4igzPAxR z&?>yQtuQb6+?;qQyyru$!u#3?duMHPZC?A^STNkGOl zx46AmOM4LzuSY;!2XFn@Guo0BIPFxbovM^PsH===mCs?doyt8sRVnFGSGiBCEVfs9 zV5cf2^Xe+^(JI$aV%ErM&W3$?NK}TiX**wfNn9q{3-3685npO7GQ>r^Q(q_Z`SxBO z-l_dwh4AxrMBC5bx1N_HQI0*d9Qz9*bK}`fjOteshv&!n zm5(0&8#*)5_t1L-=HX0q6Gs9>S3X8aS3aJJ2`2s?`fi{r6U)RypksN1pkw(&#t=}# z2N{_}2$at!3CibFnWTVHJ}8+;3}yop1=k^Ln?+j{1z{e zilc~EagCHg4X@xuQVD#YLHSuyNxTjlpCgsRCV#!ZM5+^iVzu}@DHH!<6ZrzEF8mvN z@I_MHx(d&t-$>j-w}Hs}7%*^@pM-iJcX?#;1Cc>7uP`{G^52RV9J<~~p@>OTh?m0U zIUL)ux|d?~jd;lqH&=%n|CAt$=@OZyiX;`iot`)zJ)whYZ+c>dA(cpv-GFg;6Q?f= zzbhY=iA>a=Nl2i1Q^)c#J;fN)LWxW)n9AqldMaL@V&r*JC-R1#V$k_gMldy*Pw1&c zeTtz-slDw3<5_P9{+2uNYkUb`=Kf;%C0-^K;ZeScuh0!0Y^N{dtE8ehi4}Z}RE&u} zhp&^0(^W_D4N?Za#}@ldQVBU+bqMBdGNL?OrFfuF>Nb@%-pRhrK#T=|026Iy`LK8h z)0kpQsU7S+SgRFY<)NpmvI8)eXazMY=rP4YWj zNVfD4M_DqNmEN$4+4dE|>u5>eYQGL#PRqs7>uKL*v`Z;@l|>LVn17$+HBt#uKj8Bd V{FHBfMD+4`liBt&{G7R!`5&E>HfsO? literal 6465 zcmcIo-E$jP75}X)X(f4W%XVy6O`4>s>)5hWH7zAYN=#!X!3H}GapID;KsWYcZ!Al$ zv@%Vh6e!)e`Wdr>hu6&p+dCrPcDWounArp64$ly)`y$vsYgn@)x@)qr4%~6id zrfAMS3wL2ZC9XK0b|w_es<}n_ox%ZhNKEdrFpPT*B-fo~ z*S>Idg9i466fbxcx3r>ya@fMCKs(oU)TheJS4BkD!ng!0C1G9gY_C=o_l{V&4>@|i zWS34qU9*b@21Y}YbpjN|9vARY3lHEy16_>8bZ8&@f+#e0Qc~(63m+8OaYqCzbq`z2 zx4Z#MqS^3ePar^TnD32fJZ|BH;JX!GrI9!!OCPrI2u|vynQ*G~2Evpzk}LwBws1=J zQEV4@5P}HKSonw}L}Jyhu1+&=`&bpT7CwrP85ml(*PQ8cY035;b3HDXs-9i)n32!< zVQTms3R{qKA(HRattfS4Lx4a^ILAW4nYVBjk1{KmX&ZLMxxo6$jn3^p?+RnHCO&Rp zk17SXoLg`zu3dDWwJ#SP6AQtL+LdXgL{S^9Tmz}TXJsH{rEa!bzH+WKXuazO{JZ?3## z7Z+`Ym@)H-QE$~{&?au9y|p<|b9&zKR?Exh?25hac&b4j+F?v{APQpJV6zE~qi@E{ z|KQ$b7)6KaHy)N6Yiwza1?Vd=FYC5u;0#N2_i1{o_Q*gSYpwNN8cO4;%{{E2&pZ43 zpdXi}gG9Wv1m0+1O+C}kGl6w0SiNs)LQ}Wu3rAj>m9RbBLfoZS!YY0>`kMiRO(A?# z_zm4atn95i6(*`=;BeEitX7&x0}8ah?Mc!>Xn>_6u-swzgICSn>dP$hS50P%!tXj%C#1cr6G*hR(s<3aSA`dH4{ITtHLV=h8q`3x3pPab8>nQ_3hz|z2ucER}EbA zcSf}oAE<@S*rny7Qyrcwm)B|=VP|(HLldJMh;86cgu)d>J4EtDOxwlcg6lbj1YR|; z)*6n{MrSx-OdM=24n+%UT0hi_LmorL5j^VRIAM&ji_VrxPG!1iSE~-AJk+Y(zXzN6 zrGa~QgtuMPO#Irw{@X)Y`#Qw9n-{|f|DD5m#5wYPhIhY+yjJk<16!9EVAMpALls4F@`6&_9UOqaEx$FW#594 z9p8faJ3dA5N&f9d2mc;I6!#!WO`qb^phn}f*B#Tj&xU9ZE+ZrGvIdF+v@OsdH56IjGs{dU||46eTZc6uU$|(X1)rtJsi~FbWBN z5S9tyJ(bI1&mu>0cPRUN^loEdd>eZ?ya6+M9nr`QE@`_YTEIle=b^eSLvZN5fzJ>T zLuBBQy88|(NvvR%tD^3pQU)acfCHD_!ri|m%}{=8`F(uiJB^RdaTKjF8fOYrZ-a&o zDO0q=G2ay4O|icXb8jp2oo$)b5|?# zU2T|kYP;0U7pgWEjI|0m&_;-XEA(jp)PV*i7dAlIkH=k(rD@;N0rD8Jk6?+-JA=@ zGF0WacUKOGsIF>fR*Bue4-9PSfAdzRB-lQ!1NWmBaaKlhNt za*51PM3REuOc#zvPpG8YmoBU_r4s4!>oAXO3+7JQb(4weR2 z`!%1DAGNiE#E1VYf1~ovyZtiR8Sn4Z&*K?&)dTiRLP_%QcZ|ORf0O)8y^R^5^_c7r z9h3X(_X~cJ*SQ)xsCiLrZMJ(t%t7``3Vhc;7hdD8nN0MNrfXnt_Q)0vWi!z&E@Wc7 z7iKf@EvQx=zJ(1a=`&hFy#tNZZ-gWMjhXV*eYit3$#-Zbn#|+?iK&@1|9I%;C~KFv zCdWZW4)ruer70v$_OxP@BSN1(-%Fq5P4Y#$B1heW9Hkp1vvM|UW3GKi&= Date: Fri, 26 Mar 2021 15:54:38 +0100 Subject: [PATCH 5/8] T235 Removed unnecessary methods --- .../klaus/controller/MvcExceptionHandler.java | 1 - .../model/constraints/HttpCodeValidation.java | 2 -- .../repository/MockedResponseRepository.java | 2 -- .../controller/MvcExceptionHandler.class | Bin 3438 -> 3438 bytes .../constraints/HttpCodeValidation.class | Bin 2658 -> 2658 bytes .../repository/MockedResponseRepository.class | Bin 853 -> 721 bytes 6 files changed, 5 deletions(-) diff --git a/src/main/java/com/release11/klaus/controller/MvcExceptionHandler.java b/src/main/java/com/release11/klaus/controller/MvcExceptionHandler.java index 661b48c..8990e89 100644 --- a/src/main/java/com/release11/klaus/controller/MvcExceptionHandler.java +++ b/src/main/java/com/release11/klaus/controller/MvcExceptionHandler.java @@ -10,7 +10,6 @@ import javax.validation.ConstraintViolationException; import java.util.ArrayList; import java.util.List; -//TODO: Is it really necessary? /** * Custom exception handler for {@link ConstraintViolationException} diff --git a/src/main/java/com/release11/klaus/model/constraints/HttpCodeValidation.java b/src/main/java/com/release11/klaus/model/constraints/HttpCodeValidation.java index 438e0a9..9de2675 100644 --- a/src/main/java/com/release11/klaus/model/constraints/HttpCodeValidation.java +++ b/src/main/java/com/release11/klaus/model/constraints/HttpCodeValidation.java @@ -17,7 +17,6 @@ import java.util.stream.Stream; public class HttpCodeValidation implements ConstraintValidator { private Set allowedValues; - //TODO: Find use of targetEnum /** * Initializes {@link #allowedValues} with possible http status values. * @param targetEnum HttpCode context @@ -29,7 +28,6 @@ public class HttpCodeValidation implements ConstraintValidator findAllByClientUUID(UUID clientUUID); -// TODO: Remove if no use - MockedMessage getByCompositePrimaryKey(String compositePrimaryKey); } diff --git a/target/classes/com/release11/klaus/controller/MvcExceptionHandler.class b/target/classes/com/release11/klaus/controller/MvcExceptionHandler.class index ffec9676744489820d816a4923a2d13e50dda561..b357181770930dfd1e40354a3ad82006a90d6418 100644 GIT binary patch delta 43 zcmaDS^-gL-FE^v`IN2Bhh6VCSz|O$Iz{J1_lwxIM-~v+IK+MFz b!@vw>@iOp%Mfe#6fHW6SP7p{7F)#oCke>+y delta 182 zcmcb}dX Date: Fri, 26 Mar 2021 15:56:23 +0100 Subject: [PATCH 6/8] T235 Useless class has been removed --- .../com/release11/klaus/utilis/ObjectConfig.java | 14 -------------- .../com/release11/klaus/utilis/ObjectConfig.class | Bin 657 -> 0 bytes 2 files changed, 14 deletions(-) delete mode 100644 src/main/java/com/release11/klaus/utilis/ObjectConfig.java delete mode 100644 target/classes/com/release11/klaus/utilis/ObjectConfig.class diff --git a/src/main/java/com/release11/klaus/utilis/ObjectConfig.java b/src/main/java/com/release11/klaus/utilis/ObjectConfig.java deleted file mode 100644 index 895456a..0000000 --- a/src/main/java/com/release11/klaus/utilis/ObjectConfig.java +++ /dev/null @@ -1,14 +0,0 @@ -package com.release11.klaus.utilis; - -import com.release11.klaus.model.MockedMessageDto; -import org.springframework.context.annotation.Bean; -import org.springframework.context.annotation.Configuration; - -//TODO: is it really necessary? kekw -@Configuration -public class ObjectConfig { - @Bean - public MockedMessageDto globalMessageDto(){ - return new MockedMessageDto(); - } -} diff --git a/target/classes/com/release11/klaus/utilis/ObjectConfig.class b/target/classes/com/release11/klaus/utilis/ObjectConfig.class deleted file mode 100644 index 96bd064fefd2e33fc3eabbd711338307da45ef36..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 657 zcma)(O)o=16o%hvORI|dW@+UkVZuTpL_)=?NRTF$(`#I#b7y4kT>LCn5)wbaj}m8Y zOD(!^7iV(LocFo!ne+Me_5olA3sn?QETdGz5QZ7*cj7^CElkYM+IKSY48wcMD8J88 zTv=_EQDIn%Y{H$?QlxTolXtYpQl8jrsriYGI`aBNrm2YKk+)Tp1AdfYd5|dcN~^T@ ztA;f6bMf2C z52Y}~s$SU4MeQ5 Date: Fri, 26 Mar 2021 15:59:41 +0100 Subject: [PATCH 7/8] T235 Removed unnecessary constructor --- .../release11/klaus/utilis/RedisAppender.java | 2 +- .../klaus/utilis/TrackingClient.java | 3 --- .../klaus/utilis/TrackingClient.class | Bin 1457 -> 1457 bytes 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/com/release11/klaus/utilis/RedisAppender.java b/src/main/java/com/release11/klaus/utilis/RedisAppender.java index a6dd5aa..081c2c6 100644 --- a/src/main/java/com/release11/klaus/utilis/RedisAppender.java +++ b/src/main/java/com/release11/klaus/utilis/RedisAppender.java @@ -15,7 +15,7 @@ import redis.clients.jedis.Jedis; import redis.clients.jedis.JedisPool; import redis.clients.jedis.Protocol; -//TODO: The check? Check if any of the following methods might be removed... +//TODO: Add javadoc public class RedisAppender extends UnsynchronizedAppenderBase { JedisPool pool; diff --git a/src/main/java/com/release11/klaus/utilis/TrackingClient.java b/src/main/java/com/release11/klaus/utilis/TrackingClient.java index 27fddbf..9a626bd 100644 --- a/src/main/java/com/release11/klaus/utilis/TrackingClient.java +++ b/src/main/java/com/release11/klaus/utilis/TrackingClient.java @@ -4,7 +4,6 @@ import org.slf4j.MDC; import java.util.Map; -//TODO: Check if constructor might be safely removed. It's static class tho /** * This static class has one purpose and one purpose only. It logs data about incomming requests. * The data from logs is received via {@link com.release11.klaus.repository.EventRepositoryImpl} @@ -12,8 +11,6 @@ import java.util.Map; */ public final class TrackingClient { - private TrackingClient(){} - /** * Logs data inside the given map * @param businessKeysMap map containing all the information about incomming request diff --git a/target/classes/com/release11/klaus/utilis/TrackingClient.class b/target/classes/com/release11/klaus/utilis/TrackingClient.class index 3945cde033434b935c415f92c97b634c9ad289d2..ad3b41e891cba27d90704ebff1e700264423e979 100644 GIT binary patch delta 37 tcmdnUy^(vvBo;=-$&*<$7 Date: Fri, 26 Mar 2021 16:04:25 +0100 Subject: [PATCH 8/8] T235 TODO unchecked --- src/main/java/com/release11/klaus/service/KlausServiceImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/com/release11/klaus/service/KlausServiceImpl.java b/src/main/java/com/release11/klaus/service/KlausServiceImpl.java index 851db51..2326bcd 100644 --- a/src/main/java/com/release11/klaus/service/KlausServiceImpl.java +++ b/src/main/java/com/release11/klaus/service/KlausServiceImpl.java @@ -59,7 +59,6 @@ public class KlausServiceImpl implements KlausService { .collect(Collectors.toList()); } -// TODO: check logic /** * Returns {@link MockedMessageDto} of given id and key-uuid. If message doesn't then empty message is returned * @param clientUUID the key-uuid of given set of messages