R11/release11-tools
4
2
Fork 0
Code Issues 9 Pull Requests 4 Packages Projects Releases 6 Wiki Activity

Added XSLTTemplate, functions that add it to transform area and documentation for that function #144

Merged
bema merged 2 commits from widlam/enhancement/issue#109 into master 2023-04-19 13:35:42 +02:00
Conversation 2 Commits 2 Files Changed 3 +45 -6
widlam commented 2023-04-18 13:44:29 +02:00
Collaborator
Copy Link
No description provided.
widlam added 1 commit 2023-04-18 13:44:31 +02:00
Added XSLTTemplate, functions that add it to transform area and documentation for that function 48a740bafd
widlam requested review from bema 2023-04-18 13:56:29 +02:00
bema requested changes 2023-04-18 14:10:27 +02:00
bema left a comment
Collaborator
Copy Link

I found two things to correct.

The "Insert default XSLT" still has "defaultXMLButton" id.

Regarding lines 55-58:
Putting "style" attribute in html tags should be avoided when styling of this tag isn't modified using JS. We have enough of that, there is no need to add more ;) There is defined div class "display-space-beetween" used to place the elements in the same way as you did. It's used in lines 19-42, you can model after that code. AFAIK, this is just flexbox with spacing set.

I found two things to correct. The "Insert default XSLT" still has "defaultXMLButton" id. Regarding lines 55-58: Putting "style" attribute in html tags should be avoided when styling of this tag isn't modified using JS. We have enough of that, there is no need to add more ;) There is defined div class "display-space-beetween" used to place the elements in the same way as you did. It's used in lines 19-42, you can model after that code. AFAIK, this is just flexbox with spacing set.
bema changed title from Added XSLTTemplate, functions that add it to transform area and documentation for that function to WIP: Added XSLTTemplate, functions that add it to transform area and documentation for that function 2023-04-18 14:11:35 +02:00
widlam added 1 commit 2023-04-19 08:47:47 +02:00
Change button ID, remove style attribute from html fdaec4e8e3
bema approved these changes 2023-04-19 13:35:25 +02:00
bema changed title from WIP: Added XSLTTemplate, functions that add it to transform area and documentation for that function to Added XSLTTemplate, functions that add it to transform area and documentation for that function 2023-04-19 13:35:31 +02:00
bema merged commit 093c8756b1 into master 2023-04-19 13:35:42 +02:00
bema deleted branch widlam/enhancement/issue#109 2023-04-19 13:35:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
bema
Labels
Clear labels
JSON Formatter
Regarding JSON Formatter tool
REST Mock
Regarding REST Mock Services tool
Spike
Something to brainstorm
XML Formatter
Regarding XML Formatter tool
XPath
Regarding XPath tool
XQuery
Regarding XQueryr tool
XSD
Regarding XSD tool
XSLT
Regarding XSLT tool
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
high priority
maintenence/refactor
Things that don't implement new functionality or fix bugs, but help keeping codebase clean
medium priority
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
administrator bartosz bema boguckib dudzikp koleckia szewczyw widlam
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: R11/release11-tools#144
No description provided.
Delete Branch "widlam/enhancement/issue#109"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?