Implemented XML Formatter and simplified structure of XML tools #229

Merged
bema merged 33 commits from ref/simplify_xml_tools into master 2023-06-21 14:32:02 +02:00
Collaborator
No description provided.
bema added 9 commits 2023-06-19 10:43:28 +02:00
bema requested review from widlam 2023-06-19 10:43:42 +02:00
bema added 1 commit 2023-06-19 11:24:28 +02:00
bema added 1 commit 2023-06-19 11:34:09 +02:00
bema added 2 commits 2023-06-19 11:45:46 +02:00
bema added 1 commit 2023-06-19 11:57:54 +02:00
bema added 1 commit 2023-06-20 10:22:46 +02:00
bema added 1 commit 2023-06-20 12:28:56 +02:00
bema added 3 commits 2023-06-20 12:36:36 +02:00
bema added 1 commit 2023-06-20 13:01:03 +02:00
bema added 1 commit 2023-06-20 13:12:52 +02:00
bema added 2 commits 2023-06-20 13:30:13 +02:00
bema added 1 commit 2023-06-20 13:38:26 +02:00
bema added 1 commit 2023-06-20 14:15:17 +02:00
bema added 1 commit 2023-06-20 14:33:24 +02:00
bema added 1 commit 2023-06-20 14:44:30 +02:00
bema added 1 commit 2023-06-21 09:23:34 +02:00
widlam requested changes 2023-06-21 12:37:46 +02:00
@@ -1,7 +1,5 @@
declare namespace p="http://www.release11.com/person";
declare namespace b="http://www.release11.com/book";
declare namespace l="http://www.release11.com/library";
declare default element namespace "http://www.tibco.com/schemas/Shemy4tools/Folder/Schema.xsd";
Collaborator

Try to get rid of these "tibco" watermark

Try to get rid of these "tibco" watermark
@@ -0,0 +8,4 @@
const props = defineProps(
{
prettyName: {type: String, required: true}
Collaborator

prettifiedName, or something else.
Name imo should be more descriptive.

prettifiedName, or something else. Name imo should be more descriptive.
@@ -0,0 +2,4 @@
const props = defineProps({
xml: {type: String, required: true},
isMinimizer: {type: Boolean}
Collaborator

isMinimizer boolean it's good option, when we have only two options, but in future when we'll need to add another option like for example "removeNamespaces" we need refactor larger piece of code. I suggest to make prop "formatType", with type String.

isMinimizer boolean it's good option, when we have only two options, but in future when we'll need to add another option like for example "removeNamespaces" we need refactor larger piece of code. I suggest to make prop "formatType", with type String.
bema added 3 commits 2023-06-21 12:38:58 +02:00
bema added 2 commits 2023-06-21 13:18:19 +02:00
Author
Collaborator

Implemented first two of suggested, regarding third I think that it's not probable that we will need third mode in formatter component and until we do that this would be only made code less readable. Therefore I will not implement that for now.

Implemented first two of suggested, regarding third I think that it's not probable that we will need third mode in formatter component and until we do that this would be only made code less readable. Therefore I will not implement that for now.
bema requested review from widlam 2023-06-21 13:22:34 +02:00
widlam approved these changes 2023-06-21 14:28:21 +02:00
bema changed title from WIP: Implemented XML Formatter and simplified structure of XML tools to Implemented XML Formatter and simplified structure of XML tools 2023-06-21 14:31:50 +02:00
bema merged commit f16639b45e into master 2023-06-21 14:32:02 +02:00
bema deleted branch ref/simplify_xml_tools 2023-06-21 14:32:03 +02:00
Sign in to join this conversation.
No description provided.