Removed duplicate code and adjusted captions #249

Merged
bema merged 15 commits from ref-func/cleaning_upload into master 2023-10-26 13:44:13 +02:00
2 changed files with 14 additions and 23 deletions
Showing only changes of commit a02e0f46ba - Show all commits

View File

@@ -37,10 +37,8 @@ public class XmlController implements RestController {
XMLRequestBody requestBody; XMLRequestBody requestBody;
try { try {
requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class); requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class);
} catch (Exception e) { } catch (Exception ex) {
XMLResponseBody responseBody = prepareErrorResponseBody(e.getMessage(), "N/A"); requestErrorResponse(response, ex);
response.status(400);
response.body(this.gson.toJson(responseBody));
return; return;
} }
@@ -66,11 +64,8 @@ public class XmlController implements RestController {
XMLRequestBody requestBody; XMLRequestBody requestBody;
try { try {
requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class); requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class);
} catch (Exception e) { } catch (Exception ex) {
XMLResponseBody responseBody = prepareErrorResponseBody(e.getMessage(), "N/A"); requestErrorResponse(response, ex);
response.status(400);
response.body(this.gson.toJson(responseBody));
return; return;
} }
if (requestBody.getProcessor() == null) { if (requestBody.getProcessor() == null) {
@@ -89,11 +84,8 @@ public class XmlController implements RestController {
XMLRequestBody requestBody; XMLRequestBody requestBody;
try { try {
requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class); requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class);
} catch (Exception e) { } catch (Exception ex) {
XMLResponseBody responseBody = prepareErrorResponseBody(e.getMessage(), "N/A"); requestErrorResponse(response, ex);
response.status(400);
response.body(this.gson.toJson(responseBody));
return; return;
} }
@@ -114,10 +106,7 @@ public class XmlController implements RestController {
try { try {
requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class); requestBody = this.gson.fromJson(request.body(), XMLRequestBody.class);
} catch (Exception e) { } catch (Exception e) {
XMLResponseBody responseBody = prepareErrorResponseBody(e.getMessage(), "N/A"); requestErrorResponse(response, e);
response.status(400);
response.body(this.gson.toJson(responseBody));
return; return;
} }
@@ -213,8 +202,10 @@ public class XmlController implements RestController {
response.status(400); response.status(400);
} }
private void requestErrorResponse(Response response) { private void requestErrorResponse(Response response, Exception ex) {
XMLResponseBody responseBody = prepareErrorResponseBody(ex.getMessage(), "N/A");
response.status(400);
response.body(this.gson.toJson(responseBody));
} }
private XMLResponseBody prepareErrorResponseBody(String message, String processor) { private XMLResponseBody prepareErrorResponseBody(String message, String processor) {

View File

@@ -40,7 +40,7 @@ public class Saxon implements XmlEngine{
} }
/** /**
* This method evaluates XQuery exporession on given xml * This method evaluates XQuery expression on given xml
* @param data xml * @param data xml
* @param xquery expression * @param xquery expression
* @return * @return
@@ -64,8 +64,8 @@ public class Saxon implements XmlEngine{
/** /**
* Process xpath and return either node or wrapped atomic value * Process xpath and return either node or wrapped atomic value
* @param data xml to be querried * @param data xml to be processed
* @param query xpath queryy * @param query xpath query
* @param version processor version * @param version processor version
* @return string xml representation of the node * @return string xml representation of the node
* @throws Exception thrown on node building errors or invalid xpath * @throws Exception thrown on node building errors or invalid xpath